Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): properly replace curlies that match multiple times in a row #522

Merged
merged 1 commit into from
Mar 30, 2022
Merged

fix(core): properly replace curlies that match multiple times in a row #522

merged 1 commit into from
Mar 30, 2022

Conversation

xavdid
Copy link
Contributor

@xavdid xavdid commented Mar 30, 2022

Fixes bug introduced in core version 11.1.1 where a quirk with regex objects wouldn't replace multiple curly strings in a row

@xavdid xavdid requested a review from standielpls March 30, 2022 21:25
@xavdid xavdid requested a review from eliangcs as a code owner March 30, 2022 21:25
standielpls
standielpls approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@standielpls standielpls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xavdid xavdid merged commit 1bbca20 into master Mar 30, 2022
@xavdid xavdid deleted the IDENT-480 branch March 30, 2022 21:32
@eliangcs
Copy link
Member

Thanks for fixing! For reference, the bug was introduced by #428. And this is not the first time we get bitten by RegExp.test(): #467.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@standielpls standielpls standielpls approved these changes

@eliangcs eliangcs Awaiting requested review from eliangcs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xavdid @eliangcs @standielpls