Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUPPORTENG-385] Clarifying how fields accept file types #582

Merged
merged 3 commits into from
Oct 17, 2022

Conversation

justin-lee-zapier
Copy link
Contributor

Description

I added some additional language to how Zapier processes file types in fields. It looks like our user help docs provide some more additional details than our developer docs. So this will bring the developer docs in line with what we have that is public facing.

Changelog

Add

Additional information on how we process strings and that we make a GET request when we detect a URL.

Copy link
Member

@eliangcs eliangcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@justin-lee-zapier the files under docs/build/ are auto generated. What you'd want to edit instead is the FieldSchema.js file, for which I've gone ahead and pushed a commit to this PR. Please merge it if the change also looks good to you. Thanks!

@justin-lee-zapier
Copy link
Contributor Author

Ah! Okay, thanks for making that change @eliangcs . This looks good, merging now!

@justin-lee-zapier justin-lee-zapier merged commit adce83f into master Oct 17, 2022
@justin-lee-zapier justin-lee-zapier deleted the SUPPORTENG-385 branch October 17, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants