PDE-3732 feat(cli): Implement individual field flags for register command #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kola-er
reviewed
Feb 7, 2023
eliangcs
reviewed
Feb 9, 2023
eliangcs
reviewed
Feb 10, 2023
| allowNo: true, | ||
| }), | ||
| }, | ||
| }); | ||
| RegisterCommand.examples = [ | ||
| 'zapier register', | ||
| 'zapier register "My Cool Integration"', |
There was a problem hiding this comment.
Can we add some more examples here?
eliangcs
reviewed
Feb 10, 2023
Remove non-functional "Learn more" text from homepage URL flag description Co-authored-by: Kola Erinoso <kola-er@users.noreply.github.com>
…egister.js Co-authored-by: Chang-Hung Liang <chang-hung.liang@zapier.com>
…ds/register.js Co-authored-by: Chang-Hung Liang <chang-hung.liang@zapier.com>
…f/hooks/getAppRegistrationFieldChoices.js Co-authored-by: Chang-Hung Liang <chang-hung.liang@zapier.com>
This enables us to see all available options when running `zapier register --help`
eliangcs
reviewed
Feb 13, 2023
There was a problem hiding this comment.
I added a few more suggestions in the review. To summarize what we've discussed, I think this is ready to merge once these are also addressed:
- write unit tests for the
registercommand- use
nockto mockfields-choicesendpoint - remove test-related code from
register.js - remove smoke tests
- use
- add the 140-char limit check for the
--descriptionflag - add some valid examples for the
registercommand - add
?formId=createin the API call sosubscriptiongets saved (related Slack conversation)
tests * Move nock from devDependencies to dependencies in CLI package.json * Add chai to devDependencies (requirement of @oclif/test) * Remove mock/testing code from getAppRegistrationFieldChoices hook
* This commit refactors the prompt validation to allow for multiple custom validators * This commit refactors the RegisterCommand tests to be more uniform with the BaseCommand test
…hen validating enum fields Co-authored-by: Chang-Hung Liang <chang-hung.liang@zapier.com>
* This commit also utilizes nock for API requests in "zapier register should enforce character limits on flags" test cases
eliangcs
approved these changes
Feb 15, 2023
|
@eliangcs Nice! I was struggling to hide stdout/stderr for some reason on my local, so I'm glad you updated that. I'm going to merge this PR now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds prompts for required information when running
zapier register. It also allows users to pass these values in via flags.