Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PDE-3732 feat(cli): Implement individual field flags for register command #618

Merged
merged 21 commits into from
Feb 16, 2023
Merged

PDE-3732 feat(cli): Implement individual field flags for register command #618

merged 21 commits into from
Feb 16, 2023

Commits on Feb 10, 2023

  1. Add optional required option and validation to prompt in `ZapierBaseC… 

    …ommand` class
    @gregilo
    gregilo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    f9151f1 View commit details
    Browse the repository at this point in the history

  2. Move nock from devDependencies to dependencies in CLI package.json

    @gregilo
    gregilo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3a4aed6 View commit details
    Browse the repository at this point in the history

  3. Add fixture for register field choices API response

    @gregilo
    gregilo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3aad044 View commit details
    Browse the repository at this point in the history

  4. Mock API call for register field choices when testing

    @gregilo
    gregilo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    af927cd View commit details
    Browse the repository at this point in the history

  5. Add error handling for API call for register field choices

    @gregilo
    gregilo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    eebe168 View commit details
    Browse the repository at this point in the history

  6. Implement interactive prompts and individual field flags for register… 

    … command
    @gregilo
    gregilo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    5fc33aa View commit details
    Browse the repository at this point in the history

  7. Update packages/cli/src/oclif/commands/register.js 

    Remove non-functional "Learn more" text from homepage URL flag description

Co-authored-by: Kola Erinoso <kola-er@users.noreply.github.com>
    @gregilo @kola-er
    gregilo and kola-er committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    3e8ad70 View commit details
    Browse the repository at this point in the history

  8. Update audience flag description in packages/cli/src/oclif/commands/r… 

    …egister.js

Co-authored-by: Chang-Hung Liang <chang-hung.liang@zapier.com>
    @gregilo @eliangcs
    gregilo and eliangcs committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    fae6431 View commit details
    Browse the repository at this point in the history

  9. Update homepage URL flag description in packages/cli/src/oclif/comman… 

    …ds/register.js

Co-authored-by: Chang-Hung Liang <chang-hung.liang@zapier.com>
    @gregilo @eliangcs
    gregilo and eliangcs committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    4fa06df View commit details
    Browse the repository at this point in the history

  10. Include caught error object in error message in packages/cli/src/ocli… 

    …f/hooks/getAppRegistrationFieldChoices.js

Co-authored-by: Chang-Hung Liang <chang-hung.liang@zapier.com>
    @gregilo @eliangcs
    gregilo and eliangcs committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    cb985fe View commit details
    Browse the repository at this point in the history

  11. Set flag options for register command dynamically 

    This enables us to see all available options when running `zapier register --help`
    @gregilo
    gregilo committed Feb 10, 2023
    Configuration menu
    Copy the full SHA
    abcadd3 View commit details
    Browse the repository at this point in the history

Commits on Feb 13, 2023

  1. Move register command tests out of smoke-tests and into separate unit 

    tests

* Move nock from devDependencies to dependencies in CLI package.json
* Add chai to devDependencies (requirement of @oclif/test)
* Remove mock/testing code from getAppRegistrationFieldChoices hook
    @gregilo
    gregilo committed Feb 13, 2023
    Configuration menu
    Copy the full SHA
    5825c47 View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2023

  1. Enforce character limit on description field/flag 

    * This commit refactors the prompt validation to allow for multiple custom
validators
* This commit refactors the RegisterCommand tests to be more uniform
  with the BaseCommand test
    @gregilo
    gregilo committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    4610f36 View commit details
    Browse the repository at this point in the history

  2. Use constant for max description length for register command

    @gregilo
    gregilo committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    3b57747 View commit details
    Browse the repository at this point in the history

  3. Add ?formId=create to API call for zapier register command

    @gregilo
    gregilo committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c536cb8 View commit details
    Browse the repository at this point in the history

  4. Simplify logic for determining if provided flag has a field mapping w… 

    …hen validating enum fields

Co-authored-by: Chang-Hung Liang <chang-hung.liang@zapier.com>
    @gregilo @eliangcs
    gregilo and eliangcs committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    08e8ca4 View commit details
    Browse the repository at this point in the history

  5. Add more examples for zapier register command

    @gregilo
    gregilo committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    286afb7 View commit details
    Browse the repository at this point in the history

  6. Utilize object.entries in register.js

    @gregilo
    gregilo committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    093aef9 View commit details
    Browse the repository at this point in the history

  7. Add test to ensure flags work properly for zapier register command 

    * This commit also utilizes nock for API requests in "zapier register should enforce character limits on flags" test cases
    @gregilo
    gregilo committed Feb 14, 2023
    Configuration menu
    Copy the full SHA
    c9ebfe4 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2023

  1. Suppress stdout and stderr when running tests

    @eliangcs
    eliangcs committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    8b34c45 View commit details
    Browse the repository at this point in the history

  2. Replace fs.statSync with fs.existsSync

    @eliangcs
    eliangcs committed Feb 15, 2023
    Configuration menu
    Copy the full SHA
    568c066 View commit details
    Browse the repository at this point in the history