Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly detect a daily Cron and show the Daily tab #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryrobbo
Copy link

@ryrobbo ryrobbo commented Apr 20, 2020

Issue:
Creating a daily Cron then making it the default expression pre-selects the "Advanced" tab instead of the "Daily" tab. This is an issue when persisting an expression then revisiting it to change/review it.

Reproducible steps:
On the Daily tab, create a Cron that will run every 1 day(s) at any specific time. Take the resulting expression and set it as the component's default expression.

Notes:
It seems the code that normalises the expression converts;

30 6 1/1 * * => 30 6 * * *

The changes in this PR handle this situation and shows the "Default" tab.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant