Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Composer 2 #16

Closed
danepowell opened this issue Apr 20, 2020 · 4 comments · Fixed by #17
Closed

Support for Composer 2 #16

danepowell opened this issue Apr 20, 2020 · 4 comments · Fixed by #17

Comments

@danepowell
Copy link
Contributor

Composer 2 will be released soon, and plugins such as composer-drupal-optimizations need to be modified to support it: composer/composer#8726

danepowell added a commit to danepowell/composer-drupal-optimizations that referenced this issue Apr 22, 2020
@danepowell
Copy link
Contributor Author

Perhaps we should centralize discussion in #17, but note my comment there about performance: Composer 2 is so much more efficient than Composer 1 that you might not even need this plugin.

@Berdir
Copy link

Berdir commented Oct 7, 2020

I agree that it is very likely no longer required for composer 2. Maybe it could just do nothing if it detects composer v2? that would make it easier to keep it in project (templates) as not everyone will be able to switch to composer 2 at the same time, and by removing it, you'd expose the composer 1 users to the performance issues again.

@zaporylie
Copy link
Owner

@Berdir See #17 - I agree with you hence I return early from the Plugin if Composer 2 is detected.

@gitressa
Copy link
Contributor

Perhaps something like this could be added to the About section in the README file?

This composer-plugin contains a set of improvements that makes running heavy duty composer commands (i.e. composer update or composer require) much faster.

Probably not needed for Composer 2, since it is quite fast by default.

Last line added ^^, which I have created a MR for: #26.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants