Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #26

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Update README.md #26

merged 2 commits into from
Oct 22, 2020

Conversation

gitressa
Copy link
Contributor

Adds comment about Composer 2 probably not needing the plug-in.

Adds comment about Composer 2 probably not needing the plug-in.
@gitressa gitressa mentioned this pull request Oct 13, 2020
Copy link
Owner

@zaporylie zaporylie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution. This can go in once #17 is in but could you rephrase it a bit? I think the key message we wanna send to people is that plugin is disabled if Composer 2 is detected and if everyone involved in project development is using Composer 2 then this plugin becomes redundant and can as well be just removed from the list of project dependencies.

Rephrases Composer 2 info text.
@gitressa
Copy link
Contributor Author

Sure, I have tried rephrasing the text, to make it clearer, and gave it a sub-heading to make it stand out a bit. What do you think?

@zaporylie
Copy link
Owner

I like it!

@gitressa
Copy link
Contributor Author

Awesome! And thanks for making the plug-in the first place, and speeding up Composer and Drupal :)

@gitressa gitressa closed this Oct 13, 2020
@gitressa gitressa reopened this Oct 13, 2020
@gitressa
Copy link
Contributor Author

I accidentally closed and quickly reopened the PR, which might have made the continuous-integration/travis-ci/pr build fail ... Perhaps you can trigger a re-build somehow?

@zaporylie
Copy link
Owner

Build failure is expected and will be fixed by #17. Stay tuned.

@gitressa
Copy link
Contributor Author

I see, thanks for clarifying. I tried yesterday to link this issue to the main issue, but without luck ... you probably need write permissions or something. From #17:

linked-issues

@zaporylie zaporylie merged commit a7f409a into zaporylie:master Oct 22, 2020
@gitressa gitressa deleted the readme_composer2 branch October 22, 2020 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants