Firefox Integration tests #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: aryangupta701 <garyan447@gmail.com>
aryangupta701
force-pushed
the
firefoxTest
branch
from
5a4b729
to
470e383
Compare
|
I think it is not yet supported by playwright : microsoft/playwright#7297 |
aryangupta701
force-pushed
the
firefoxTest
branch
4 times, most recently
from
04f11f3
to
20714f4
Compare
psiinon
requested changes
May 15, 2023
source/Background/index.ts
Outdated
| console.log(`ZAP Service worker calling ZAP on ${zapurl}`); | ||
| console.log(zapApiUrl(zapurl, 'reportObject')); | ||
| console.log(encodeURIComponent(zapkey)); | ||
| // console.log(`ZAP Service worker calling ZAP on ${zapurl}`); |
There was a problem hiding this comment.
The commented out additions should all be removed 😁
| import * as http from 'http'; | ||
| import fs from 'fs'; | ||
|
|
||
| describe('Firefox Integration Test', () => { |
There was a problem hiding this comment.
Theres lots of code common with the chrome test here.
We should just have one test which covers both browsers.
Where we need to do things diffferently then we should either wrap the tests, pass in parameters or call broweser specific functions.
aryangupta701
force-pushed
the
firefoxTest
branch
2 times, most recently
from
ec840dd
to
13c9772
Compare
Signed-off-by: aryangupta701 <garyan447@gmail.com>
aryangupta701
force-pushed
the
firefoxTest
branch
from
13c9772
to
afd0a66
Compare
psiinon
approved these changes
May 15, 2023
thc202
approved these changes
May 15, 2023
|
Thank you! |
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integration tests for firefox.