Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Lint javascript for license header and add licence to js files #843

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

jveldhuijzen
Copy link

Adds license header files to javascript and lints the javascript files.
Fixes #1

Signed-off-by: J.Veldhuijzen <j.veldhuijzen@tools4ever.com>
Signed-off-by: J.Veldhuijzen <j.veldhuijzen@tools4ever.com>
@jveldhuijzen jveldhuijzen force-pushed the lint-javascript-for-license-header branch from cad2da9 to 0198356 Compare November 24, 2020 15:43
*
* ZAP is an HTTP/HTTPS proxy for assessing web application security.
*
* Copyright $YEAR The ZAP Development Team
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has the year as token.

Comment on lines -1128 to -1129
// FIXME: remove after #620
// eslint-disable-next-line no-unsanitized/property
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted.

@thc202 thc202 changed the title Lint javascript for license header and add licence to js files [WIP] Lint javascript for license header and add licence to js files Dec 7, 2020
@thc202
Copy link
Member

thc202 commented Dec 7, 2020

Changed to WIP per above comments.

@thc202
Copy link
Member

thc202 commented Mar 9, 2021

@jveldhuijzen do you still plan to work on this?

@jveldhuijzen
Copy link
Author

Well.. it's been busy. Where I left this off was that the lib used to to the linting (and fixing the header) wasn't able to do a replacement of the $year variable.
I was busy with extending that lib (eslint-plugin-license-header) and wanted to setup a PR for them but all the unit tests for that project kept failing on my W10 machine, and I was planning on trying this out in a linux vm to see what would happen there.

So yeah, I'll try that project out in a linux vm to see where it leads me with the unit testing.
I'll report back soon.

@thc202
Copy link
Member

thc202 commented Mar 9, 2021

Thank you.

@jveldhuijzen
Copy link
Author

As you may've wondered, I'm not getting around fixing this the right way. So I'll leave this PR for someone else to continue upon or do you guys want to close this?
Running the test for that other project does work on a linux machine, not a Windows machine.

@nothingismagick
Copy link
Contributor

Its funny, I've been looking for something like this for JS (after building it in rust over at https://github.com/tauri-apps/tauri ) - I have a couple cycles free this week and can pick this one up if you like @thc202

@thc202
Copy link
Member

thc202 commented Apr 27, 2021

That sounds good to me, I guess you would have to create a new PR (as you'll not be able to change this?). We can leave it open in the meantime though.

@nothingismagick
Copy link
Contributor

nothingismagick commented Apr 27, 2021

Would you prefer a proper SPDX approach? If so, who is the exact copyright holder?

@thc202
Copy link
Member

thc202 commented Apr 27, 2021

I don't think it needs to be but if it addresses the issue. We go with "The ZAP Development Team".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

License Header
4 participants