Client Certificates Web API Support #5166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Outstanding:
|
kingthorin
force-pushed
the
client-cert-api
branch
from
8ec5ea9
to
9e87713
Compare
kingthorin
changed the title
kingthorin
force-pushed
the
client-cert-api
branch
from
9e87713
to
111a257
Compare
|
Rebased current and fixed an issue with not setting the index param.
I'm not sure that's a major issue, there seem to be other places within the options panels where API initiated changes aren't properly reflected in the GUI. |
kingthorin
force-pushed
the
client-cert-api
branch
4 times, most recently
from
b99fab2
to
df6b6cd
Compare
thc202
reviewed
Feb 13, 2019
Allow PCKS12 Client Certificate to be specified and enabled via the web API. Allow Client Certificate handling to be disabled via the web API. Fixes zaproxy#2023
kingthorin
force-pushed
the
client-cert-api
branch
from
df6b6cd
to
4188cb7
Compare
kingthorin
changed the title
thc202
approved these changes
Feb 14, 2019
|
Thanks! |
psiinon
approved these changes
Feb 14, 2019
|
@kingthorin would you mind updating the release notes to mention the new API endpoints? |
|
Will do. |
|
Thanks! |
kingthorin
added a commit
to kingthorin/zap-core-help
that referenced
this pull request
Feb 18, 2019
kingthorin
added a commit
to kingthorin/zap-core-help
that referenced
this pull request
Feb 18, 2019
Follow-up to: zaproxy#215 zaproxy/zaproxy#5166 In the API section I also removed two spurious spaces on the setOptionAddQueryParam section.
This was referenced Feb 25, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on: #4892
Allow PCKS12 Client Certificate to be specified and enabled via the web
API.
Allow Client Certificate handling to be disabled via the web API.
Fixes #2023