-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make Alert_on_Unexpected_Content_Types.js more forgiving #8524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c64b49
to
8666b86
Compare
kingthorin
commented
Jun 19, 2024
docker/scripts/scripts/httpsender/Alert_on_Unexpected_Content_Types.js
Outdated
Show resolved
Hide resolved
thc202
reviewed
Jun 19, 2024
docker/scripts/scripts/httpsender/Alert_on_Unexpected_Content_Types.js
Outdated
Show resolved
Hide resolved
thc202
reviewed
Jun 19, 2024
zap/src/test/java/org/parosproxy/paros/network/HttpHeaderUnitTest.java
Outdated
Show resolved
Hide resolved
8666b86
to
03b73a7
Compare
Fixed |
4bf9635
to
aaed3fa
Compare
thc202
reviewed
Jun 19, 2024
docker/scripts/scripts/httpsender/Alert_on_Unexpected_Content_Types.js
Outdated
Show resolved
Hide resolved
thc202
reviewed
Jun 19, 2024
aaed3fa
to
1def7d8
Compare
CHANGELOG tweaked |
- CHANGELOG > Added change note. - Alert_on_Enexpected_Content_Type.js > Leverage "HttpHeader.hasContentType" to be more forgiving. - HttpHeaderUnitTest > Add test to ensure behavior is as expected and that vargs will accept an array. Signed-off-by: kingthorin <kingthorin@users.noreply.github.com>
1def7d8
to
b296967
Compare
Fixed |
thc202
approved these changes
Jun 19, 2024
Thank you! |
ricekot
approved these changes
Jun 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8522