Skip to content

Commit

Permalink
mr_list: fix order and sort flags description
Browse files Browse the repository at this point in the history
Two modifications were made with this patch for both order and sort flags:

1) remove the explicit "default" value that was being printed in the middle
of the description: viper CLI already prints the default value at the end of
the description;
2) show the options within "()" instead of a continous sentence, following
other options pattern.

Signed-off-by: Bruno Meneguele <bmeneg@redhat.com>
  • Loading branch information
bmeneg committed Jan 4, 2021
1 parent 72141b2 commit 4293972
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cmd/mr_list.go
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,8 @@ func init() {
listCmd.Flags().BoolVarP(&mrMine, "mine", "m", false, "list only MRs assigned to me")
listCmd.Flags().StringVar(
&mrAssignee, "assignee", "", "list only MRs assigned to $username")
listCmd.Flags().StringVar(&order, "order", "updated_at", "display order, updated_at(default) or created_at")
listCmd.Flags().StringVar(&sortedBy, "sort", "desc", "sort order, desc(default) or asc")
listCmd.Flags().StringVar(&order, "order", "updated_at", "display order (updated_at/created_at)")
listCmd.Flags().StringVar(&sortedBy, "sort", "desc", "sort order (desc/asc)")
listCmd.Flags().BoolVarP(&mrDraft, "draft", "", false, "list MRs marked as draft")
listCmd.Flags().BoolVarP(&mrReady, "ready", "", false, "list MRs not marked as draft")
listCmd.Flags().SortFlags = false
Expand Down

0 comments on commit 4293972

Please sign in to comment.