Documentation for configuration #2
Comments
|
Commit 503913e changed the flow so configuration values are prompted for when not present (ie on first run). Likewise a README now exists with some better information. Let me know if this is suitable! |
|
👍 |
Closed
bmeneg
pushed a commit
that referenced
this issue
Mar 26, 2021
The problem with cmd/mr_test.go:cleanupMR() is that the way it is called is insufficient to clean up a failed test. The sequence that is leading to failures is, for example, test run #1: Test_mrCmd() runs. Test_mrCmd_MR_description_and_options() runs and fails leaving, for example, a Merge Request with description "Fancy Description". test run #1 fails. test run #2: Test_mrCmd() runs and fails because a Merge Request with description "Fancy Description" exists. It is not "found" by the cleanupMR() function because Test_mrCmd()'s call is looking for a description of "mr title". test run #2 fails. test run #3 (with my changes from the first commit) cleans things up. test run #3 fails. test run #4 should succeed. This is a painful way to test. Since only one MR is created at a time for the test branch the code should just clean up any existing MR. Add wildcard support to the cleanupMR() function. Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The text was updated successfully, but these errors were encountered: