Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable pytest rewriting in test helper functions. #185

Merged
merged 2 commits into from
Apr 21, 2019

Conversation

QuLogic
Copy link
Contributor

@QuLogic QuLogic commented Mar 28, 2019

If you call a helper function from numcodecs.tests.common and it fails, pytest will show a generic assertion message. But with assertion rewriting enabled, it will shows its full verbose output (i.e., expanding left and write values, showing local variables, etc.)

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py37 passes locally
  • tox -e py27 passes locally
  • [N/A] Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

Copy link
Member

@alimanfoo alimanfoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I didn't know about this, thank you!

Happy to merge once CI passes.

@jakirkham jakirkham merged commit 20176a7 into zarr-developers:master Apr 21, 2019
@jakirkham
Copy link
Member

Thanks @QuLogic :)

@QuLogic QuLogic deleted the pytest-rewrite branch April 21, 2019 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants