Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop LegacyJSON codec #225

Closed
alimanfoo opened this issue Apr 2, 2020 · 3 comments · Fixed by #226
Closed

Drop LegacyJSON codec #225

alimanfoo opened this issue Apr 2, 2020 · 3 comments · Fixed by #226

Comments

@alimanfoo
Copy link
Member

We recently dropped the LegacyMsgPack codec (#218). The LegacyJSON codec was deprecated around the same time, I think we could remove it now too.

@jakirkham
Copy link
Member

Agreed. That would be good to drop 🙂

@joshmoore
Copy link
Member

joshmoore commented Sep 23, 2022

The fact that there is only a json2 and not json codec came up last night during the ZEP call while reviewing the codecs registry work.

Somehow I missed that this dropped support for the codec ID and not just an implementation. We might want to think about getting numcodecs to 1.0 so that we can clearly mark such bumps with a major version change.

@jakirkham
Copy link
Member

In SemVer, with 0.x releases each increase in x can break the API (hence dropping here is allowed). This happened in 0.7.0.

We left the keys alone as both json and json2 are still valid. One would just need an older version of Numcodecs to read the former.

Interestingly the two JSON implementations are a good example of the codec versioning question raised in spec issue ( zarr-developers/zarr-specs#148 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants