Skip to content

Conversation

@jrbourbeau
Copy link
Member

Fixes #225

TODO:

  • Unit tests and/or doctests in docstrings
  • tox -e py38 passes locally
  • Docstrings and API docs for any new/modified user-facing classes and functions
  • Changes documented in docs/release.rst
  • tox -e docs passes locally
  • AppVeyor and Travis CI passes
  • Test coverage to 100% (Coveralls passes)

@pep8speaks
Copy link

pep8speaks commented Apr 2, 2020

Hello @jrbourbeau! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 102:1: E402 module level import not at top of file

Comment last updated at 2020-04-02 18:41:06 UTC

@jakirkham jakirkham merged commit d142cb3 into zarr-developers:master Apr 2, 2020
@jakirkham
Copy link
Member

Thanks James! 😄

@jrbourbeau jrbourbeau deleted the remove-legacy-json branch April 2, 2020 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop LegacyJSON codec

3 participants