Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run Zarr CI tests out-of-tree #1347

Open
jakirkham opened this issue Feb 10, 2023 · 2 comments
Open

Run Zarr CI tests out-of-tree #1347

jakirkham opened this issue Feb 10, 2023 · 2 comments
Labels
maintenance Work needed by a maintainer

Comments

@jakirkham
Copy link
Member

Currently we run Zarr tests in-tree, which means things like fixture are present. However these might not show up correctly when installing the package (for example: #1312 (comment) ). If Zarr were installed on CI (similar to how a user would) and then we changed to a different directory (outside of the Zarr source tree), we should be able to catch this installation issues within PRs.
@jakirkham jakirkham added the maintenance Work needed by a maintainer label Feb 10, 2023
@jakirkham jakirkham mentioned this issue Feb 10, 2023
Merged
6 tasks
joshmoore added a commit to joshmoore/zarr-python that referenced this issue Feb 12, 2023
@joshmoore
Generate fixture for zarr-developers#1312 if it is missing
aab38f6 
This is a temporary fix for the larger issue of out-of-tree
testing described in zarr-developers#1347, but this should allow a release
of 2.14.1 which passes on conda.
@joshmoore joshmoore mentioned this issue Feb 12, 2023
Merged
6 tasks
joshmoore added a commit that referenced this issue Feb 12, 2023
@joshmoore
Generate fixture for #1312 if it is missing (#1348)
76fce14 
This is a temporary fix for the larger issue of out-of-tree
testing described in #1347, but this should allow a release
of 2.14.1 which passes on conda.
@joshmoore joshmoore mentioned this issue Feb 12, 2023
Closed
3 tasks
@MSanKeys963
Copy link
Member

Hi @jakirkham. Thanks for opening the issue.

After conda-forge/zarr-feedstock#73 failed yesterday, I tried to understand what was going wrong and had a small discussion with @joshmoore.

One of the ways that Josh suggested was that if we move fixture under zarr it would solve this, but we would be shipping the fixture every time during Zarr installation. This would increase the package's overall size and maybe the installation time.

Is there any way you think we can approach this problem?

Also, CC'ing @zarr-developers/python-core-devs if you have any thoughts on this.

@jakirkham
Copy link
Member Author

In the past one typically would use MANIFEST.in to include the data files in the sdist, but not necessarily packages (to keep from getting bloated).

Would suggest running through some of the options here.

setuptools_scm may also have a better way to handle this.

joshmoore added a commit to joshmoore/zarr-python that referenced this issue Mar 10, 2023
@joshmoore
Don't use relative fixture path
6ddb9bd 
see: zarr-developers#1312
see: zarr-developers#1347
see: zarr-developers#1348
@joshmoore joshmoore mentioned this issue Mar 10, 2023
Merged
6 tasks
joshmoore added a commit that referenced this issue Mar 10, 2023
@joshmoore
Don't use relative fixture path (#1364)
6e63fe9 
see: #1312
see: #1347
see: #1348
@joshmoore joshmoore mentioned this issue Mar 16, 2023
Merged
6 tasks
@joshmoore joshmoore mentioned this issue Apr 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Work needed by a maintainer
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakirkham @MSanKeys963