Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate fixture for #1312 if it is missing #1348

Merged
merged 1 commit into from Feb 12, 2023

Conversation

joshmoore
Copy link
Member

This is a temporary fix for the larger issue of out-of-tree testing described in #1347, but this should allow a release of 2.14.1 which passes on conda.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

This is a temporary fix for the larger issue of out-of-tree
testing described in zarr-developers#1347, but this should allow a release
of 2.14.1 which passes on conda.
@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Feb 12, 2023
@joshmoore joshmoore mentioned this pull request Feb 12, 2023
6 tasks
@codecov
Copy link

codecov bot commented Feb 12, 2023

Codecov Report

Merging #1348 (aab38f6) into main (4e8b84b) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main     #1348   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines        14744     14752    +8     
=========================================
+ Hits         14744     14752    +8     
Impacted Files Coverage Δ
zarr/tests/test_attrs.py 100.00% <100.00%> (ø)
zarr/util.py 100.00% <0.00%> (ø)
zarr/indexing.py 100.00% <0.00%> (ø)
zarr/tests/test_hierarchy.py 100.00% <0.00%> (ø)

@joshmoore joshmoore merged commit 76fce14 into zarr-developers:main Feb 12, 2023
@joshmoore joshmoore deleted the utf8attrs-fix branch February 12, 2023 08:26
@jakirkham
Copy link
Member

Maybe this code provides an idea on how to approach fixtures?

fixture = group(store=DirectoryStore('fixture'))

joshmoore added a commit to joshmoore/zarr-python that referenced this pull request Mar 10, 2023
@joshmoore joshmoore mentioned this pull request Mar 10, 2023
6 tasks
joshmoore added a commit that referenced this pull request Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants