Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require setuptools_scm version 1.5.4+ #1477

Merged
merged 3 commits into from
Jul 20, 2023
Merged

Require setuptools_scm version 1.5.4+ #1477

merged 3 commits into from
Jul 20, 2023

Conversation

jakirkham
Copy link
Member

This use to be a requirement in setup.py, but it got lost in the pyproject.yaml migration

zarr-python/setup.py

Line 28 in d6e35a5

'setuptools-scm>1.5.4',

So readding it here

Also this lines up with the conda-forge recipe requirement on setuptools_scm

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 20, 2023
@jakirkham jakirkham removed the needs release notes Automatically applied to PRs which haven't added release notes label Jul 20, 2023
@jakirkham jakirkham mentioned this pull request Jul 20, 2023
Merged
5 tasks
@jakirkham jakirkham requested a review from jhamman July 20, 2023 21:37
@jakirkham jakirkham enabled auto-merge (squash) July 20, 2023 21:55
@jakirkham jakirkham merged commit f3ba0b1 into zarr-developers:main Jul 20, 2023
19 checks passed
@rabernat rabernat mentioned this pull request Aug 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakirkham @jhamman