Array & Group: Use already loaded attributes to populate cache. #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcherian
changed the title
jhamman
reviewed
Mar 30, 2024
dcherian
force-pushed
the
use-cached-attrs
branch
from
0d6c3f5
to
4350a18
Compare
dcherian
force-pushed
the
use-cached-attrs
branch
from
4350a18
to
0df8761
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1734 +/- ##
==========================================
- Coverage 99.99% 99.98% -0.01%
==========================================
Files 38 38
Lines 14610 14614 +4
==========================================
+ Hits 14609 14612 +3
- Misses 1 2 +1
|
* main: Couple fixes (zarr-developers#1737) Bump actions/setup-python from 5.0.0 to 5.1.0 (zarr-developers#1736) Optimize Array.info and Group.info (zarr-developers#1733) chore: update pre-commit hooks (zarr-developers#1738)
rabernat
approved these changes
Apr 4, 2024
jhamman
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Description of PR]
Spotted this quick (possible) optimization.
_load_metadata(two lines above) has already downloaded the attributes. May as well populate the cache ahead of the time ifcache_attrs is True(which is the default)TODO: