Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

expose codecov token in ci #1473

Merged
merged 1 commit into from
Jul 20, 2023
Merged

expose codecov token in ci #1473

merged 1 commit into from
Jul 20, 2023

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jul 19, 2023

Perhaps this resolves #1472

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions bot added the needs release notes Automatically applied to PRs which haven't added release notes label Jul 19, 2023
jhamman
jhamman approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Seems to have worked!

@rabernat rabernat merged commit a5d8a95 into zarr-developers:main Jul 20, 2023
21 checks passed
@d-v-b d-v-b deleted the add_codecov_token branch July 20, 2023 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman approved these changes

Assignees
No one assigned
Labels
needs release notes Automatically applied to PRs which haven't added release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Codecov uploads failing
3 participants
@d-v-b @jhamman @rabernat