Add example hypothesis roundtrip test #1746
Conversation
|
Hello @dcherian! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-04-05 17:47:12 UTC |
tests/test_properties.py
Outdated
| elif path == "/": | ||
| assert name is not None | ||
| array_path = name | ||
| array_name = "/" + name | ||
| else: | ||
| assert name is not None | ||
| array_path = f"{path}/{name}" | ||
| array_name = "/" + array_path |
dcherian
force-pushed
the
hypothesis-tests
branch
from
0a97842
to
42b88dc
Compare
1. Roundtrip a numpy array 2. Basic Indexing
This is important for zarr-developers#1931
This reverts commit 2ad1b35.
dcherian
force-pushed
the
hypothesis-tests
branch
from
42b88dc
to
a772880
Compare
dcherian
force-pushed
the
hypothesis-tests
branch
from
4e71735
to
bd90c6a
Compare
|
Some input needed:
|
| # TODO: clean this up | ||
| if path is None and name is None: |
| assert isinstance(a, Array) | ||
| assert nparray.shape == a.shape | ||
| # assert chunks == a.chunks # TODO: adapt for v2, v3 | ||
| assert array_path == a.path | ||
| assert array_name == a.name | ||
| # assert a.basename is None # TODO | ||
| # assert a.store == normalize_store_arg(store) | ||
| assert dict(a.attrs) == expected_attrs |
There was a problem hiding this comment.
Would be good to decide what invariants to check here. Potentially could move out to its own test.
| # TODO: FIXME seems to break with booleans and timedelta | ||
| # fill_value=nparray.dtype.type(0), |
There was a problem hiding this comment.
the boolean issue is probably a bug, would be good to see if we can extract a standalone reproducer.
|
Some input here would be very helpful |
| # TODO: FIXME seems to break with booleans and timedelta | ||
| # fill_value=nparray.dtype.type(0), |
There was a problem hiding this comment.
the boolean issue is probably a bug, would be good to see if we can extract a standalone reproducer.
* v3: (22 commits) [v3] `Buffer` ensure correct subclass based on the `BufferPrototype` argument (zarr-developers#1974) Fix doc build (zarr-developers#1987) Fix doc build warnings (zarr-developers#1985) Automatically generate API reference docs (zarr-developers#1918) Update `RemoteStore.__str__` and add UPath tests (zarr-developers#1964) [v3] Elevate codec pipeline (zarr-developers#1932) 0 dim arrays: indexing (zarr-developers#1980) `parse_shapelike` allows 0 (zarr-developers#1979) Clean up typing and docs for indexing (zarr-developers#1961) add json indentation to config (zarr-developers#1952) chore: update pre-commit hooks (zarr-developers#1973) Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#1969) chore: update pre-commit hooks (zarr-developers#1957) Update release.rst (zarr-developers#1960) doc: update release notes for 3.0.0.alpha (zarr-developers#1959) Basic working FsspecStore (zarr-developers#1785) Feature: Top level V3 API (zarr-developers#1884) Buffer Prototype Argument (zarr-developers#1910) Create issue-metrics.yml fixes bug in transpose (zarr-developers#1949) ...
After
mamba install hypothesisUse
to see all the things it tries.
This was a quick attempt at a property test.
The other thing you can do is a "Stateful" test (e.g. https://github.com/pydata/xarray/blob/main/properties/test_index_manipulation.py)
which runs an arbitrary sequence of manipulations (e.g. add array, rename, move, delete, modify array, copy), and checks for consistency at each point.
cc @Zac-HD
TODO: