Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parse_shapelike allows 0 #1979

Merged
merged 4 commits into from
Jun 21, 2024
Merged

parse_shapelike allows 0 #1979

merged 4 commits into from
Jun 21, 2024

Conversation

d-v-b
Copy link
Contributor

@d-v-b d-v-b commented Jun 18, 2024 •
edited
Loading

  • parse_shapelike allows shape values to be 0
  • parse_shapelike allows the empty tuple ()
  • parse_shapelike rejects negative integers correctly (in main this is not working)
  • expands tests accordingly

response to #1976 and #1977, although I'm not sure it addresses those concerns entirely, since I haven't changed array indexing tests at all

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@d-v-b d-v-b mentioned this pull request Jun 18, 2024
Merged
6 tasks
jhamman
jhamman reviewed Jun 18, 2024
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, left you a few small suggestions.

src/zarr/common.py Show resolved Hide resolved
tests/v3/test_common.py Show resolved Hide resolved
@d-v-b d-v-b merged commit 6fc05b7 into zarr-developers:v3 Jun 21, 2024
18 checks passed
@tomwhite tomwhite mentioned this pull request Jun 24, 2024
Closed
dcherian added a commit to dcherian/zarr-python that referenced this pull request Jun 25, 2024
@dcherian
Merge branch 'v3' into hypothesis-tests
3a560ed 
* v3: (22 commits)
  [v3] `Buffer` ensure correct subclass based on the `BufferPrototype` argument (zarr-developers#1974)
  Fix doc build (zarr-developers#1987)
  Fix doc build warnings (zarr-developers#1985)
  Automatically generate API reference docs (zarr-developers#1918)
  Update `RemoteStore.__str__` and add UPath tests (zarr-developers#1964)
  [v3] Elevate codec pipeline (zarr-developers#1932)
  0 dim arrays: indexing (zarr-developers#1980)
  `parse_shapelike` allows 0 (zarr-developers#1979)
  Clean up typing and docs for indexing (zarr-developers#1961)
  add json indentation to config (zarr-developers#1952)
  chore: update pre-commit hooks (zarr-developers#1973)
  Bump pypa/gh-action-pypi-publish in the actions group (zarr-developers#1969)
  chore: update pre-commit hooks (zarr-developers#1957)
  Update release.rst (zarr-developers#1960)
  doc: update release notes for 3.0.0.alpha (zarr-developers#1959)
  Basic working FsspecStore (zarr-developers#1785)
  Feature: Top level V3 API (zarr-developers#1884)
  Buffer Prototype Argument (zarr-developers#1910)
  Create issue-metrics.yml
  fixes bug in transpose (zarr-developers#1949)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamman jhamman jhamman left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@d-v-b @jhamman