Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some ruff rules (RUF) and fix issues #1869

Merged
merged 4 commits into from
May 14, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 12, 2024

Note: #1867 is the same applied to the main branch

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

RUF010 Use explicit conversion flag
RUF019 Unnecessary key check before dictionary access
RUF100 Unused `noqa` directive
@normanrz normanrz merged commit c31a785 into zarr-developers:v3 May 14, 2024
18 checks passed
@normanrz normanrz added the V3 Related to compatibility with V3 spec label May 14, 2024
@DimitriPapadopoulos DimitriPapadopoulos deleted the RUF_v3 branch May 14, 2024 14:31
@jhamman jhamman added this to the 3.0.0.alpha milestone May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 Related to compatibility with V3 spec
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants