Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable some ruff rules (RUF) and fix issues #1867

Closed

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 12, 2024

Note: #1869 is the same applied to the v3 branch

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

RUF010 Use explicit conversion flag
RUF019 Unnecessary key check before dictionary access
RUF100 Unused `noqa` directive
Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.98%. Comparing base (bf89533) to head (fdb5c0e).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1867   +/-   ##
=======================================
  Coverage   99.98%   99.98%           
=======================================
  Files          38       38           
  Lines       14695    14695           
=======================================
  Hits        14693    14693           
  Misses          2        2           
Files with missing lines Coverage Δ
zarr/_storage/absstore.py 100.00% <ø> (ø)
zarr/_storage/store.py 100.00% <100.00%> (ø)
zarr/core.py 100.00% <100.00%> (ø)
zarr/meta.py 100.00% <ø> (ø)
zarr/n5.py 100.00% <100.00%> (ø)
zarr/tests/test_sync.py 100.00% <100.00%> (ø)

@jhamman jhamman added the V3 Affects the v3 branch label May 16, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone May 16, 2024
@jhamman jhamman removed the V3 Affects the v3 branch label May 17, 2024
@jhamman jhamman removed this from the 3.0.0.alpha milestone May 17, 2024
@jhamman
Copy link
Member

jhamman commented Jun 1, 2024

@DimitriPapadopoulos - thanks for moving your focus over to the v3 branch. I'm going to close this in favor of the contributions you've already made there. 🙏

@jhamman jhamman closed this Jun 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants