Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ruff/flake8-raise rules (RSE) and fix issues #1872

Merged
merged 2 commits into from
May 17, 2024

Conversation

DimitriPapadopoulos
Copy link
Contributor

@DimitriPapadopoulos DimitriPapadopoulos commented May 13, 2024

Note: #1866 is the same applied to the main branch

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/tutorial.rst
  • Changes documented in docs/release.rst
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@MSanKeys963 MSanKeys963 added the V3 Related to compatibility with V3 spec label May 15, 2024
@jhamman jhamman added this to the 3.0.0.alpha milestone May 16, 2024
@normanrz
Copy link
Contributor

Hi @DimitriPapadopoulos, #1890 just landed. Can you please take another look how your PRs might be affected? Thanks!

@DimitriPapadopoulos
Copy link
Contributor Author

Rebased.

RSE102 Unnecessary parentheses on raised exception
@jhamman jhamman merged commit 333f37f into zarr-developers:v3 May 17, 2024
18 checks passed
@DimitriPapadopoulos DimitriPapadopoulos deleted the RSE_v3 branch May 17, 2024 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V3 Related to compatibility with V3 spec
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants