WIP: Fix getsize to be recursive
#362
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure the `DirectoryStore`'s `getsize` method checks each directory recursively when computing the storage size of a directory.
jakirkham
commented
Dec 10, 2018
zarr/tests/test_storage.py
Outdated
| @@ -210,7 +210,7 @@ def test_hierarchy(self): | |||
| store['c/d/x'] | |||
|
|
|||
| # test getsize (optional) | |||
| if hasattr(store, 'getsize'): | |||
| if hasattr(store, 'getsize') and not isinstance(store, DirectoryStore): | |||
There was a problem hiding this comment.
Skipped DirectoryStore instances as we were not seeing the exact same sizes on disk as recorded here.
There was a problem hiding this comment.
Actually it looks like if we expect a recursive storage size check, the tests below are incorrect (e.g. store.getsize() == 15). So am a bit confused about what behavior we would like to have going forward.
As users expect `getsize` to be recursive, update our tests to ensure `getsize`'s results are checked against what the recursive result would be.
|
Hi @jakirkham, just going through some old emails and noticed this is still open. Did you want to revisit? |
|
Sure happy to do that. Though it may take me a little bit to get back to this. So it's totally fine if someone beats me to it 🙂 |
|
@jakirkham : can this be closed thanks to #431? |
|
Yep thanks for catching that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #253
Make sure the
DirectoryStore'sgetsizemethod checks each directory recursively when computing the storage size of a directory.TODO:
tox -e docs)