Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark ZEP 1 as accepted. #260

Merged
merged 1 commit into from Aug 10, 2023
Merged

Mark ZEP 1 as accepted. #260

merged 1 commit into from Aug 10, 2023

Conversation

jstriebel
Copy link
Member

@jstriebel jstriebel commented Aug 10, 2023 •
edited

  • Remove sphinxmark extension.
  • Add custom draft mark mechanism to ZEP 2 pages.
  • Update status of specs and consolidate headers.

Built upon #258.

Previews:

@jstriebel
Mark ZEP 1 as accepted.
cccfb0d 
* Remove sphinxmark extension.
* Add custom draft mark mechanism to ZEP 2 pages.
* Update status of specs and consolidate headers.
@jstriebel jstriebel requested a review from jbms August 10, 2023 06:45
@jstriebel jstriebel self-assigned this Aug 10, 2023
This was referenced Aug 10, 2023
Closed
Closed
jhamman
jhamman approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@jhamman jhamman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jstriebel! This looks good to me.

joshmoore
joshmoore approved these changes Aug 10, 2023
View reviewed changes
Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MSanKeys963 points out this only works on Chrome at the moment (or at least, not on Firefox). I'll sign-off and merge, erring on the side of making ZEP0001 look good, but if anyone can take a look at making this cross-browser compatible, I'll send an internet 🍪.

@joshmoore joshmoore merged commit 8741619 into main Aug 10, 2023
1 check passed
@joshmoore joshmoore deleted the mark-zep1-accepted branch August 10, 2023 16:37
@jstriebel
Copy link
Member Author

PS: The problem for Firefox is the support for the has css selector: https://caniuse.com/css-has
This might be solved ™️ soonish, see this thread.

@MSanKeys963 MSanKeys963 mentioned this pull request Aug 10, 2023
Merged
@mkitti mkitti mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmoore joshmoore joshmoore approved these changes

@jhamman jhamman jhamman approved these changes

@jbms jbms Awaiting requested review from jbms

Assignees

@jstriebel jstriebel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jstriebel @joshmoore @jhamman