Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update V3 status and minor fixes. #261

Merged
merged 1 commit into from Aug 24, 2023

Conversation

MSanKeys963
Copy link
Member

Hi everyone. 👋🏻

Building this on #260.

The changes in this PR are as follows:

  • After going through the recent changes introduced by Mark ZEP 1 as accepted. #260, I realised the date for ZEP0001 acceptance was mentioned as 13th May. The actual date for acceptance is 15th May, when the last vote came in. Check here and here.

  • Also, we're mentioning Zarr core development team in the specification documents. This shows no team members, and this link throws a 404 to anyone outside our GitHub org. I suggest we remove the hyperlink until we make the teams public, which is visible to everyone (especially users outside the org).

Please have a look and let me know your thoughts.

CC: @zarr-developers/zep1-editors @jhamman

@joshmoore
Copy link
Member

LGTM. Did you look into redirecting from the "draft" URL? (Sorry if that was handled elsewhere?)

@joshmoore
Copy link
Member

joshmoore commented Aug 11, 2023

Also: we might want to make a list of all of these follow-up steps that are required after a ZEP is accepted (...in ZEP0000?)

e.g., #227 (comment) etc. etc.

@MSanKeys963
Copy link
Member Author

LGTM. Did you look into redirecting from the "draft" URL? (Sorry if that was handled elsewhere?)

Thanks, @joshmoore. I've already added the redirect from draftaccepted.

I've just changed the links in the specification document for clarity.

we might want to make a list of all of these follow-up steps that are required after a ZEP is accepted

Created zarr-developers/zeps#44 for this.

Copy link
Member

@joshmoore joshmoore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@joshmoore joshmoore merged commit 97453eb into zarr-developers:main Aug 24, 2023
1 check passed
@MSanKeys963 MSanKeys963 deleted the update_V3_status branch August 24, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants