Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expand/collapse functions to ui.tree and warn when using the expand_all prop #1704

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

falkoschindler
Copy link
Contributor

When using the default_expand_all prop for ui.tree, the expanded nodes are not synchronized correctly (see #1385).

This PR adds a new parameter default_expand_all for ui.tree, so the prop isn't needed anymore. Furthermore, it warns when the prop "default_expand_all" is still used. It also adds pytests for ui.tree with and without this parameter being set.

@falkoschindler falkoschindler added this to the 1.3.16 milestone Sep 28, 2023
@falkoschindler falkoschindler linked an issue Sep 28, 2023 that may be closed by this pull request
@falkoschindler falkoschindler added the bug Something isn't working label Sep 28, 2023
@falkoschindler
Copy link
Contributor Author

falkoschindler commented Oct 5, 2023

@rodja I replaced the default_expand_all parameter with expand() and collapse() methods. Ready for review.

@rodja rodja changed the title Add default_expand_all parameter and warn when using the prop Add expand/collapse functions to ui.tree and warn when using the expand_all prop Oct 6, 2023
@rodja rodja merged commit 9b4e46d into main Oct 6, 2023
2 of 6 checks passed
@rodja rodja deleted the tree-expand-all branch October 6, 2023 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tree prop 'default-expand-all'
2 participants