Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: major rewrite of SRA download workflow #157

Merged
merged 13 commits into from Feb 3, 2024
Merged

fix: major rewrite of SRA download workflow #157

merged 13 commits into from Feb 3, 2024

Conversation

mkatsanto
Copy link
Collaborator

@mkatsanto mkatsanto commented Feb 2, 2024

Description

  • Reimplementation of SRA download workflow with subworkflows for single and paired end samples
  • Query sequencing mode (i.e., whether the library is single- or paired-ended) from SRA database (rather then setting after download based on number of generated FASTQ files)
  • Add workflow test for Singularity and include in CI
  • Restrict Snakemake version (<8) in zarp Conda environment to

Fixes #132
Fixes #156

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

Conventional Commits guidelines

Checklist:

  • My code changes follow the style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • I have updated the project's documentation

@mkatsanto mkatsanto added bug Something isn't working documentation Improvements or additions to documentation ci Continuous integration and testing breaking-change Breaking changes labels Feb 2, 2024
@uniqueg uniqueg changed the title BREAKING CHANGE: Restructuring the SRA download workflow fix: major rewrite of SRA download workflow Feb 3, 2024
@github-actions github-actions bot removed the breaking-change Breaking changes label Feb 3, 2024
uniqueg
uniqueg previously approved these changes Feb 3, 2024
@uniqueg uniqueg enabled auto-merge (squash) February 3, 2024 18:54
@uniqueg uniqueg merged commit 6db184c into dev Feb 3, 2024
11 checks passed
@uniqueg uniqueg deleted the issue_132_pigz branch February 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci Continuous integration and testing documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SRA download workflow does not execute with Singularity fix: segfault upon SRA download workflow reruns
2 participants