Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some errors are emitted to stdout instead of stderr #161

Open
tpluscode opened this issue Aug 22, 2023 · 5 comments
Open

Some errors are emitted to stdout instead of stderr #161

tpluscode opened this issue Aug 22, 2023 · 5 comments
Labels
bug Something isn't working 🎯 core good first issue Good for newcomers

Comments

@tpluscode
Copy link
Contributor

No description provided.

@tpluscode tpluscode added good first issue Good for newcomers bug Something isn't working labels Aug 22, 2023
@giacomociti
Copy link
Contributor

browsing history I noticed commit 9bb6520 changed console.error(err) to console.log(err). Maybe we should just revert to using console.error?

@tpluscode
Copy link
Contributor Author

Good catch. There should be no console at all

@giacomociti
Copy link
Contributor

not sure about removing console altogether, at least the error message for multiple roots is useful (see the related PR)

@ktk
Copy link
Member

ktk commented Nov 9, 2023

Not sure if that changed but console.log was or is synchronous so it's better to use an abstraction for logging that can write to console but doesn't do so unless we tell it to. Not sure what's the latest and greates logger though.

@giacomociti
Copy link
Contributor

yes, we have the proper logging abstractions in place and all the other telemetry stuff. My guess is that this is a special case because we are at the boundaries of the system, where even the logging abstractions may not be available yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🎯 core good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants