Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore log to stderr #200

Merged
merged 2 commits into from
Nov 9, 2023
Merged

fix: restore log to stderr #200

merged 2 commits into from
Nov 9, 2023

Conversation

giacomociti
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Nov 9, 2023

🦋 Changeset detected

Latest commit: 0e5cb97

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
barnard59 Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1891143) 92.64% compared to head (0e5cb97) 92.64%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   92.64%   92.64%           
=======================================
  Files         207      207           
  Lines       11148    11148           
=======================================
  Hits        10328    10328           
  Misses        820      820           
Flag Coverage Δ
barnard59-base 66.33% <ø> (ø)
barnard59-core 96.54% <ø> (ø)
barnard59-csvw 92.13% <ø> (ø)
barnard59-formats 53.95% <ø> (ø)
barnard59-ftp 91.47% <ø> (ø)
barnard59-graph-store 98.58% <ø> (ø)
barnard59-http 94.19% <ø> (ø)
barnard59-rdf 98.06% <ø> (ø)
barnard59-s3 97.56% <ø> (ø)
barnard59-sparql 98.28% <ø> (ø)
barnard59-validate-shacl 97.60% <ø> (ø)
barnard59-validation 97.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
packages/cli/bin/barnard59.js 89.71% <100.00%> (ø)
packages/cli/test/barnard59.test.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giacomociti
Copy link
Contributor Author

should address #161

Copy link
Contributor

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so the only ones left are in the CLI. Then they are not the problem of stream errors being written to the output. Anyway, let's merge this

@giacomociti giacomociti merged commit 400c739 into master Nov 9, 2023
26 of 27 checks passed
@giacomociti giacomociti deleted the restore-stderr branch November 9, 2023 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants