fix: allow temporal ordinal dimension (as currently established for F…

…OAG and NFI)
zazuko · Apr 18, 2024 · d289758 · d289758
1 parent 214b479
commit d289758
Show file tree

Hide file tree

Showing 5 changed files with 45 additions and 4 deletions.
diff --git a/.changeset/dull-pets-push.md b/.changeset/dull-pets-push.md
@@ -0,0 +1,5 @@
+---
+"cube-link": patch
+---
+
+`profile-visualize`: allowed temporal dimensions (`meta:dataKind a time:GeneralDateTimeDescription`) to have ordinal scale type
diff --git a/test/profile-visualize/invalid-temporal.ttl b/test/profile-visualize/invalid-temporal.ttl
@@ -43,7 +43,7 @@ ex:Cube
     sh:closed true ;
     sh:property
         [
-            # no datatype, no time:unitType
+            # no datatype, no time:unitType, not qudt:scaleType qudt:OrdinalScale
             schema:name "Year" ;
             sh:path <y> ;
             sh:nodeKind sh:Literal ;

diff --git a/test/profile-visualize/invalid-temporal.ttl.approved.txt b/test/profile-visualize/invalid-temporal.ttl.approved.txt
@@ -38,14 +38,14 @@ _:report a sh:ValidationReport ;
 		sh:sourceShape <https://cube.link/shape/profile-opendataswiss-lindas#TemporalDimensionConstraint> ;
 		sh:focusNode _:b3 ;
 		sh:value _:b3 ;
-		sh:resultMessage "Temporal dimension must be one of XSD datatypes: gYear, gYearMonth, date, dateTime, or have time:unitType" ;
+		sh:resultMessage "Temporal dimension must be one of XSD datatypes: gYear, gYearMonth, date, dateTime, or have time:unitType, or have an ordinal scaleType" ;
 	], [
 		rdf:type sh:ValidationResult ;
 		sh:resultSeverity sh:Violation ;
 		sh:sourceConstraintComponent sh:XoneConstraintComponent ;
 		sh:sourceShape <https://cube.link/shape/profile-opendataswiss-lindas#TemporalDimensionConstraint> ;
 		sh:focusNode _:b5 ;
 		sh:value _:b5 ;
-		sh:resultMessage "Temporal dimension must be one of XSD datatypes: gYear, gYearMonth, date, dateTime, or have time:unitType" ;
+		sh:resultMessage "Temporal dimension must be one of XSD datatypes: gYear, gYearMonth, date, dateTime, or have time:unitType, or have an ordinal scaleType" ;
 	] ;
 	sh:conforms false .
diff --git a/test/profile-visualize/valid-temporal.ttl b/test/profile-visualize/valid-temporal.ttl
@@ -97,6 +97,31 @@ ex:Cube
             sh:maxCount 1 ;
             qudt:scaleType qudt:NominalScale ;
         ],
+        [
+            schema:name "Ordinal-Month" ;
+            sh:path <ordinalAny> ;
+            sh:nodeKind sh:IRI ;
+            meta:dataKind
+                [
+                    a time:GeneralDateTimeDescription ;
+                    time:unitType time:unitMonth ;
+                ] ;
+            sh:minCount 1 ;
+            sh:maxCount 1 ;
+            qudt:scaleType qudt:OrdinalScale ;
+        ],
+        [
+            schema:name "Ordinal-AnyPeriod" ;
+            sh:path <ordinalAny> ;
+            sh:nodeKind sh:IRI ;
+            meta:dataKind
+                [
+                    a time:GeneralDateTimeDescription ;
+                ] ;
+            sh:minCount 1 ;
+            sh:maxCount 1 ;
+            qudt:scaleType qudt:OrdinalScale ;
+        ],
         [
             sh:path rdf:type ;
             sh:nodeKind sh:IRI ;

diff --git a/validation/profile-visualize.ttl b/validation/profile-visualize.ttl
@@ -181,7 +181,7 @@ prefix : <https://cube.link/shape/profile-opendataswiss-lindas#>
     a sh:NodeShape ;
     sh:targetClass time:GeneralDateTimeDescription ;
     sh:message
-        "Temporal dimension must be one of XSD datatypes: gYear, gYearMonth, date, dateTime, or have time:unitType" ;
+        "Temporal dimension must be one of XSD datatypes: gYear, gYearMonth, date, dateTime, or have time:unitType, or have an ordinal scaleType" ;
     sh:xone
         (
             [
@@ -204,5 +204,16 @@ prefix : <https://cube.link/shape/profile-opendataswiss-lindas#>
                         sh:maxCount 1 ;
                     ] ;
             ]
+            [
+                sh:property
+                    [
+                        sh:path ( [ sh:inversePath meta:dataKind ] qudt:scaleType ) ;
+                        sh:hasValue qudt:OrdinalScale ;
+                    ],
+                    [
+                        sh:path time:unitType ;
+                        sh:maxCount 0 ;
+                    ]
+            ]
         )
 .