Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: /ref/hash/shape links #133

Merged
merged 4 commits into from
Dec 19, 2023
Merged

feat: /ref/hash/shape links #133

merged 4 commits into from
Dec 19, 2023

Conversation

tpluscode
Copy link
Contributor

No description provided.

Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 0b0d81e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cube-link Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ludovicm67 ludovicm67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a few issues that were breaking the links to shapes:

  • refs were not caught, as it was introducing an extra path layer
  • specific versions were not handled ; it was returning the last one instead

With the suggestions I made, it should work.

To try it locally, just install the dependencies using:

npm install

Run the Trifid instance by using:

npm run trifid:local

And you can run the following cUrl commands:

# latest
curl http://localhost:8080/latest/shape/standalone-cube-constraint

# get a specific version (you can see the old base)
curl http://localhost:8080/v0.0.1/shape/standalone-cube-constraint

# get current state from main branch
curl http://localhost:8080/ref/main/shape/standalone-cube-constraint

trifid/redirect.js Outdated Show resolved Hide resolved
trifid/redirect.js Outdated Show resolved Hide resolved
trifid/redirect.js Outdated Show resolved Hide resolved
trifid/redirect.js Show resolved Hide resolved
@tpluscode tpluscode merged commit 3cfa1e2 into main Dec 19, 2023
7 checks passed
@tpluscode tpluscode deleted the branch-links branch December 19, 2023 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants