Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Dataset#serialize #29

Merged
merged 7 commits into from
Oct 24, 2023
Merged

feat: Dataset#serialize #29

merged 7 commits into from
Oct 24, 2023

Conversation

tpluscode
Copy link
Collaborator

I had to wrap the dataset constructor to give it access to the environment. This way it can call the serializers via .formats

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2023

🦋 Changeset detected

Latest commit: 6569465

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@zazuko/env Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Oct 24, 2023

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (64611c4) 100.00% compared to head (c1b98ae) 95.03%.
Report is 7 commits behind head on master.

❗ Current head c1b98ae differs from pull request most recent head 245df4c. Consider uploading reports for the commit 245df4c to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##            master      #29      +/-   ##
===========================================
- Coverage   100.00%   95.03%   -4.97%     
===========================================
  Files            3        3              
  Lines           89      141      +52     
  Branches         2        3       +1     
===========================================
+ Hits            89      134      +45     
- Misses           0        7       +7     
Files Coverage Δ
packages/env/lib/Dataset.ts 96.59% <95.83%> (-3.41%) ⬇️
packages/env/lib/DatasetFactory.ts 82.60% <83.33%> (-17.40%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/env/README.md Outdated Show resolved Hide resolved
@tpluscode tpluscode merged commit fc72380 into master Oct 24, 2023
3 checks passed
@tpluscode tpluscode deleted the to-string-format branch October 24, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants