Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elcom #4

Merged
merged 17 commits into from
Aug 10, 2021
Merged

Elcom #4

merged 17 commits into from
Aug 10, 2021

Conversation

magdasalatka
Copy link
Member

No description provided.

@magdasalatka magdasalatka requested a review from ktk August 2, 2021 12:20
@RobertHenschel
Copy link
Contributor

RobertHenschel commented Aug 4, 2021

The readme starts with "Zazuko collects and publishes data from all areas of life." Is there a specific reason for wording it that strongly? Or could I change that to "Zazuko works with data from all areas of life." I just don't see Zazuko actually collect this data and publish it... we do that on behalf of our customers. Just wondering if there was a specific reason?

For now I have made a few wording changes in the README, but have not yet changed the first line.

@RobertHenschel
Copy link
Contributor

RobertHenschel commented Aug 4, 2021

folium is not listed in the requirements.txt file, but seems to be required. I did not want to add it without knowing what specific version was needed. Can I ask @magdasalatka to add the correct line to requirements.txt?

Or... does this error occur because I had used the wrong kernel in my notebook? The problem goes away if I use the "zazuko" kernel. Maybe I should have done that from the beginning. If that is the case, let me know and I can update the REAMDE to make this more clear.

@magdasalatka
Copy link
Member Author

The readme starts with "Zazuko collects and publishes data from all areas of life." Is there a specific reason for wording it that strongly? Or could I change that to "Zazuko works with data from all areas of life." I just don't see Zazuko actually collect this data and publish it... we do that on behalf of our customers. Just wondering if there was a specific reason?

For now I have made a few wording changes in the README, but have not yet changed the first line.

Sure, feel free to rephrase it. The idea behind was to point to Zazuko as "place to look for various datasets".

@magdasalatka
Copy link
Member Author

folium is not listed in the requirements.txt file, but seems to be required. I did not want to add it without knowing what specific version was needed. Can I ask @magdasalatka to add the correct line to requirements.txt?

Or... does this error occur because I had used the wrong kernel in my notebook? The problem goes away if I use the "zazuko" kernel. Maybe I should have done that from the beginning. If that is the case, let me know and I can update the REAMDE to make this more clear.

@requirements.txt: You are right. We use poetry dependencies management, so that escaped. I added it.
@kernel: You should use zazuko kernel anyway. All our dependencies are attached to this kernel.

@RobertHenschel
Copy link
Contributor

Something goes wrong for me, when I run the cell of the notebook that is supposed to plot the communes. Here is a screenshot of what happens for me. Not really sure why...
image

@RobertHenschel
Copy link
Contributor

Is the code in the section titled "Energy prices for small and big enterprises" supposed to render into a graph/map? For me it does not. I tired adding a simple "fig.show()" but that did not solve it. Can you take a look at this?
The same would be fore the code in the next section, called "Energy prices for small and big households".
Thanks!

@RobertHenschel
Copy link
Contributor

If it is easy, can we add a legend to the following plot:
image
I tried, but failed after following a few stackoverflow posts... :-( It is not a big deal... as a user finds out very quickly that most of the folks in Switzerland have only access to one provider by looking at the tooltip. But a legend would make it even more obvious.

@magdasalatka
Copy link
Member Author

magdasalatka commented Aug 9, 2021

If it is easy, can we add a legend to the following plot:
image
I tried, but failed after following a few stackoverflow posts... :-( It is not a big deal... as a user finds out very quickly that most of the folks in Switzerland have only access to one provider by looking at the tooltip. But a legend would make it even more obvious.

The legend is available under the "layers" (upper right corner). As far as I know, that is the only approach with folium.
GitHub issue: python-visualization/folium#528

What we can do:

What do you think?

@magdasalatka
Copy link
Member Author

Is the code in the section titled "Energy prices for small and big enterprises" supposed to render into a graph/map? For me it does not. I tired adding a simple "fig.show()" but that did not solve it. Can you take a look at this?
The same would be fore the code in the next section, called "Energy prices for small and big households".
Thanks!

My bet would be matplotlib and/or jupyter version mismatch. Let's take a look together in call tomorrow.

@RobertHenschel
Copy link
Contributor

I like the legend that you referenced here:

@magdasalatka magdasalatka merged commit 25c2435 into master Aug 10, 2021
@magdasalatka magdasalatka deleted the elcom branch October 19, 2021 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants