fix(proposals): 404 on non-existing proposals

zazuko · Nov 18, 2019 · c87e7aa · c87e7aa
1 parent 7763358
commit c87e7aa
Show file tree

Hide file tree

Showing 4 changed files with 23 additions and 3 deletions.
diff --git a/pages/proposal/_id.vue b/pages/proposal/_id.vue
@@ -243,6 +243,12 @@ export default {
               this.readonly = true
             }
           })
+          .catch(() => {
+            return this.$router.app.error({
+              statusCode: 404,
+              message: 'Not found'
+            })
+          })
       }, 200)
     }
   },

diff --git a/pages/proposal/class.vue b/pages/proposal/class.vue
@@ -235,6 +235,12 @@ export default {
               })
             }
           })
+          .catch(() => {
+            return this.$router.app.error({
+              statusCode: 404,
+              message: 'Not found'
+            })
+          })
       }, 200)
     }
     else {

diff --git a/pages/proposal/property.vue b/pages/proposal/property.vue
@@ -234,6 +234,12 @@ export default {
               })
             }
           })
+          .catch(() => {
+            return this.$router.app.error({
+              statusCode: 404,
+              message: 'Not found'
+            })
+          })
       }, 200)
     }
     else {

diff --git a/store/prop.js b/store/prop.js
@@ -60,15 +60,17 @@ export const actions = {
       })
 
       const proposal = result.data.proposal
+      if (!_get(proposal, 'proposalObject')) {
+        throw new Error('Not found')
+      }
       const deserialized = this.$proposalDeserializer(proposal.proposalObject)
 
       commit(LOAD, deserialized)
       commit(SET_ID, proposal.id)
-      return Promise.resolve(proposal.isDraft)
+      return proposal.isDraft
     }
     catch (error) {
-      console.error(error)
-      return Promise.reject(error)
+      throw error
     }
   },
   async [SAVE] ({ dispatch, commit, state }) {