Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #27 #28

Merged
merged 2 commits into from Dec 18, 2023
Merged

Fix #27 #28

merged 2 commits into from Dec 18, 2023

Conversation

ktk
Copy link
Member

@ktk ktk commented Dec 15, 2023 •
edited

Issue #27

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 15, 2023 •
edited

⚠️ No Changeset found

Latest commit: a7005f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ktk ktk changed the title Add more tests, 2 will fail Fix #27 Dec 15, 2023
tpluscode
tpluscode approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@tpluscode tpluscode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tpluscode tpluscode merged commit 5188f8b into master Dec 18, 2023
16 checks passed
@ktk ktk deleted the issue-27 branch December 19, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpluscode tpluscode tpluscode approved these changes

@giacomociti giacomociti Awaiting requested review from giacomociti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ktk @tpluscode