perf: reuse sh:in nodeSet #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1329680 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
tpluscode
requested changes
Apr 15, 2024
src/validators.js
Outdated
Comment on lines
136
to
144
| const inNode = constraint.getParameterValue(sh.in) | ||
| if (!constraint.nodeSets) { | ||
| constraint.nodeSets = new TermMap() | ||
| } | ||
| let nodeSet = constraint.nodeSets.get(inNode) | ||
| if (!nodeSet) { | ||
| nodeSet = new NodeSet(rdfListToArray(context.$shapes.node(inNode))) | ||
| constraint.nodeSets.set(inNode, nodeSet) | ||
| } |
There was a problem hiding this comment.
Do we need a list of node sets? I would expect a constraint object to represent a single sh:in constraint
Suggested change
| const inNode = constraint.getParameterValue(sh.in) | |
| if (!constraint.nodeSets) { | |
| constraint.nodeSets = new TermMap() | |
| } | |
| let nodeSet = constraint.nodeSets.get(inNode) | |
| if (!nodeSet) { | |
| nodeSet = new NodeSet(rdfListToArray(context.$shapes.node(inNode))) | |
| constraint.nodeSets.set(inNode, nodeSet) | |
| } | |
| if (!constraint.nodeSet) { | |
| const inNode = constraint.getParameterValue(sh.in) | |
| constraint.nodeSet = new NodeSet(rdfListToArray(context.$shapes.node(inNode))) | |
| constraint.nodeSet = new TermMap() | |
| } | |
| const { nodeSet } = constraint |
There was a problem hiding this comment.
my understanding is that all the shapes with a sh:in constraint are sharing the same instance
There was a problem hiding this comment.
I don't think so. getParameterValue gets the sh:in from the shape pointer.
tpluscode
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change boosts validation of
sh:inconstraints with long lists of allowed values.The existing implementation recreates the set of allowed nodes again and again, for each value to be validated.
With the proposed change, the node set is created only once.
To appreciate the performance gain, you may try a shapes graph like this, having a constraint with a huge list of municipalities. Try to validate a few observations
(remember to add the target declaration in the shapes graph):