Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when Multipart/Alternative is not lowercase. #21

Closed
RenierZA opened this issue Nov 10, 2016 · 1 comment
Closed

Bug when Multipart/Alternative is not lowercase. #21

RenierZA opened this issue Nov 10, 2016 · 1 comment
Labels
Milestone

Comments

@RenierZA
Copy link

RenierZA commented Nov 10, 2016

I came across a message (X-Mailer: IncrediMail) where content types were not in lowercase. This still works for most parts, but Multipart/Alternative causes getTextContent() to fail.

I'm unable to do a pull request currently, but it can be fixed by adding strtolower() in line 121 of Message.php:

private function addToAlternativeContentPartFromParsed(MimePart $part)
{
    $partType = strtolower($this->contentPart->getHeaderValue('Content-Type'));
zbateson added a commit that referenced this issue Nov 10, 2016
Fixes a few instances where case-sensitive string comparisons are
used for Content-Type.
@zbateson zbateson added the bug label Nov 10, 2016
@zbateson zbateson added this to the 0.3.2 milestone Nov 10, 2016
@zbateson
Copy link
Owner

Excellent, thanks @RenierZA

Fixed in master and will be released in 0.3.2 early December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants