Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 support #154

Merged
merged 1 commit into from
Dec 2, 2020
Merged

PHP 8.0 support #154

merged 1 commit into from
Dec 2, 2020

Conversation

phpfui
Copy link
Contributor

@phpfui phpfui commented Dec 1, 2020

Changed SplFixedArray::fromArray to new ArrayIterator for PHP 8.0

  • Unit tested on 7.1 and higher
  • My editor removes trailing spaces, but I think that is correct.

@phpfui
Copy link
Contributor Author

phpfui commented Dec 1, 2020

A merge and version would be greatly appreciated by all!

Thanks for this amazing package. Really helps dealing with reading mail.

@zbateson zbateson merged commit ef50d3b into zbateson:master Dec 2, 2020
@zbateson
Copy link
Owner

zbateson commented Dec 2, 2020

Should a new version wait considering php8 still isn't released? What if other changes are needed anyway -- just wondering on the value of creating a new version for this change when the only change in it is a fix for an unreleased version of php. Happy to do it if there's a need/reason tho :)

@phpfui
Copy link
Contributor Author

phpfui commented Dec 2, 2020

PHP 8.0 was released last week. Supported PHP versions, but the issue is TravisCI is a bit behind. Apparently the nightly build is 8.0 beta of some sort. In the past it has taken them a few weeks to support the latest release.

Since this is a minor fix, and backward compatible with older versions of PHP, I would say just release it as 1.3.1, and then people on PHP 8.0 projects can upgrade to it. Since the current version is blowing up after successfully installing under PHP 8,0, I would think you would want to do this ASAP.

And thanks for merging! I will all projects would do this.

@zbateson
Copy link
Owner

zbateson commented Dec 2, 2020

Aah, I didn't realize it was already released. New version coming, thanks for clarifying :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants