Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can’t search for package name using Chinese characters #1996

Closed
CySxL opened this issue Aug 10, 2022 · 3 comments
Closed

Can’t search for package name using Chinese characters #1996

CySxL opened this issue Aug 10, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@CySxL
Copy link

CySxL commented Aug 10, 2022

Describe the bug
Searching a Chinese letter via Zebra can't find any results. But packages with the letter are displayed if user search directly by developer's name.

To Reproduce

  1. Launch Zebra and go to search tab.

  2. Make sure Zebra has Bigboss repo added.

  3. Search for "改" via name. Which is a Chinese letter meaning "change".

  4. Zebra can't find any result for "改".

  5. Change the category of search to developer's name.

  6. Search for "小哥哥", which means "little brother".

  7. Zebra finds the results of developer's name 小哥哥, which are "改个应用..."、"改个步数..."、"定个位..."

  8. So you see the bug. The package name contains "改", but it cannot be searched by Zebra while user searches by the category of package name

Expected behavior
Display the accurate search result.

Screenshots

image
image

Device Information:

  • iOS Version: <14.8>
  • Zebra Version: <1.1.28>
  • Device Type: <iPhone 11 Pro Max>
  • Jailbreak Type: <unc0ver 8.0.2>

Crash Log or System Log
No crash log needed.

Additional context
Not sure if this helps but you can check this also : https://user-images.githubusercontent.com/15531137/183903613-e2775c25-63eb-4c77-8f07-9b35ab608efd.MOV

@CySxL CySxL added the bug Something isn't working label Aug 10, 2022
@kirb kirb changed the title Search results are not accurate Can’t search for package name using Chinese characters Aug 10, 2022
@kirb
Copy link
Member

kirb commented Dec 13, 2022

When you can, could you check if search works for you in 1.1.29? I changed a lot about how Zebra queries packages and other info from its database, and I have a feeling that should solve the problem you were having. Also note that Zebra requires at least 2 characters to perform a search. I’m not too sure why that’s the case but I’ll see if we can remove that limitation.

@CySxL
Copy link
Author

CySxL commented Dec 13, 2022

When you can, could you check if search works for you in 1.1.29? I changed a lot about how Zebra queries packages and other info from its database, and I have a feeling that should solve the problem you were having. Also note that Zebra requires at least 2 characters to perform a search. I’m not too sure why that’s the case but I’ll see if we can remove that limitation.

Yeah it is fixed now !! Thanks a lot !!image

Btw shall I pull a new issue/request for the at least 2 characters thing ?

@iAdam1n
Copy link
Member

iAdam1n commented Dec 14, 2022

Don't worry, this will be addressed shortly with Zebra 1.1.30.

@iAdam1n iAdam1n closed this as completed Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants