-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to little endian encoding for everything #12
Conversation
I'm not sure whether https://github.com/zcash/librustzcash/pull/12/files#diff-745d270700285c73dedf7767652465d7R155 and https://github.com/zcash/librustzcash/pull/12/files#diff-745d270700285c73dedf7767652465d7R159 are correct. They might be, but I recommend dropping the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
My ACK assumes that we will add test vectors generated by @str4d's independent implementation. |
We will be adding those test vectors, but this PR will not block on them. |
I have test vectors for key components, but |
We now have test coverage of Pedersen commitments, hashes, (merkle tree empty roots consistent with zcashd), note commitments, addresses/ivk, group hash, and most (all?) of jubjub. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK+cov. I generated the test vectors and wrote the tests that use them, so my ACK does not cover those.
Scalar field Fr
This depends on