Switch to little endian #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daira
approved these changes
May 17, 2018
str4d
approved these changes
May 17, 2018
| // Drop the first five bits, so it can be interpreted as a scalar. | ||
| h[0] &= 0b0000_0111; | ||
| // Drop the most significant five bits, so it can be interpreted as a scalar. | ||
| h[31] &= 0b0000_0111; |
There was a problem hiding this comment.
Spec says to interpret the BLAKE2s output as a 256-bit integer mod 2livk, and livk = 251, so this is indeed equivalent to truncating by 5 bits.
stefandeml
pushed a commit
to stefandeml/sapling-crypto
that referenced
this pull request
Jul 5, 2019
Factor out Example trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This correctly implements little endian encoding for everything in the circuit and outside abstractions.