Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't log method names to stderr unless --grpc-logging-insecure #333

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

LarryRuane
Copy link
Collaborator

@LarryRuane LarryRuane commented Jan 20, 2021

Previously, each method calls causes the following line to be logged to /dev/stderr (note, this is different from the other logging).

INFO[0007] method called    duration=5.026098ms error="<nil>" method=/cash.z.wallet.sdk.rpc.CompactTxStreamer/GetLightdInfo peer_addr="127.0.0.1:48274"

This PR removes this logging unless the --grpc-logging-insecure command-line argument is given to lightwalletd. This will prevent log files from overflowing in the default situation (must be explicitly enabled).

@LarryRuane LarryRuane self-assigned this Jan 20, 2021
@LarryRuane LarryRuane merged commit c7c5da1 into zcash:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant