You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SpendValidatingKey type is designed such that by construction, the byte encodings of ak and ak_P are identical. However, once we expose the underlying point representation, we should use the names of the individual types to match the protocol spec. So the following places in the circuit code should use ak_P:
The
SpendValidatingKey
type is designed such that by construction, the byte encodings ofak
andak_P
are identical. However, once we expose the underlying point representation, we should use the names of the individual types to match the protocol spec. So the following places in the circuit code should useak_P
:orchard/src/circuit.rs
Lines 365 to 371 in 99b767a
orchard/src/circuit.rs
Lines 593 to 594 in 99b767a
And then here, instead of implicitly creating
ak
fromak_P
, we should add alet ak = ...
above therivk
definition:orchard/src/circuit.rs
Lines 606 to 612 in 99b767a
The text was updated successfully, but these errors were encountered: