Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove wildcard imports from rpc-tests scripts to allow checking by pyflakes #2450

Closed
daira opened this issue Jun 18, 2017 · 0 comments · Fixed by #2458
Closed

Remove wildcard imports from rpc-tests scripts to allow checking by pyflakes #2450

daira opened this issue Jun 18, 2017 · 0 comments · Fixed by #2458
Assignees
@daira
Labels
A-testing Area: Tests and testing infrastructure C-cleanup Category: PRs that clean code up or issues documenting cleanup. M-has-pr To-be-removed (GitHub has linked:pr filter)
Projects
Development Infrastructure
Milestone
1.0.11 CI Deployment

Comments

@daira
Copy link
Contributor

daira commented Jun 18, 2017

pyflakes can't be used on the Python scripts under the qa/rpc-tests directory because they use wildcard imports (from ... import *). Clean up the imports to make them checkable.
@daira daira added C-cleanup Category: PRs that clean code up or issues documenting cleanup. A-testing Area: Tests and testing infrastructure labels Jun 18, 2017
@daira daira self-assigned this Jun 18, 2017
@daira daira added this to the 1.0.11 CI Deployment milestone Jun 20, 2017
daira added a commit to daira/zcash that referenced this issue Jun 20, 2017
@daira
Clean up imports to be pyflakes-checkable. fixes zcash#2450
b2712ab 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
daira added a commit to daira/zcash that referenced this issue Jun 20, 2017
@daira
For unused variables reported by pyflakes, either remove the variable,
0fa02c8 
suppress the warning, or fix a bug (if the wrong variable was used).
refs zcash#2450

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira mentioned this issue Jun 20, 2017
Merged
zkbot added a commit that referenced this issue Jun 20, 2017
@zkbot
Auto merge of #2458 - daira:2450.pyflakes-cleanup, r=<try>
248702c 
2450.pyflakes cleanup

Make the RPC tests pyflakes-clean. fixes #2450
@daira daira mentioned this issue Jun 20, 2017
Merged
daira added a commit to daira/zcash that referenced this issue Jun 22, 2017
@daira
Clean up imports to be pyflakes-checkable. fixes zcash#2450
aff0bf7 
Signed-off-by: Daira Hopwood <daira@jacaranda.org>
daira added a commit to daira/zcash that referenced this issue Jun 22, 2017
@daira
For unused variables reported by pyflakes, either remove the variable,
811b36b 
suppress the warning, or fix a bug (if the wrong variable was used).
refs zcash#2450

Signed-off-by: Daira Hopwood <daira@jacaranda.org>
@daira daira added the M-has-pr To-be-removed (GitHub has linked:pr filter) label Jun 29, 2017
@nathan-at-least nathan-at-least added this to Nominated for Release in Development Infrastructure Jul 5, 2017
@daira daira changed the title Remove wildcard imports from qa/rpc-tests scripts to allow checking by pyflakes Remove wildcard imports from rpc-tests scripts to allow checking by pyflakes Jul 6, 2017
zkbot added a commit that referenced this issue Jul 15, 2017
@zkbot
Auto merge of #2458 - daira:2450.pyflakes-cleanup, r=str4d
1738e69 
pyflakes cleanup

Make the RPC tests pyflakes-clean. fixes #2450

Includes a fix that upstream had in bitcoin/bitcoin#7802
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@daira daira

Labels
A-testing Area: Tests and testing infrastructure C-cleanup Category: PRs that clean code up or issues documenting cleanup. M-has-pr To-be-removed (GitHub has linked:pr filter)
Projects
No open projects
Development Infrastructure
  
Work Queue
Milestone
1.0.11 CI Deployment
Development

Successfully merging a pull request may close this issue.

pyflakes cleanup daira/zcash
1 participant
@daira