Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make NU peer management logic in ProcessMessage() upgrade-agnostic #3487

Closed
str4d opened this issue Aug 27, 2018 · 2 comments
Closed

Make NU peer management logic in ProcessMessage() upgrade-agnostic #3487

str4d opened this issue Aug 27, 2018 · 2 comments
Assignees
@str4d
Labels
A-networking Area: Networking code network upgrade management
Milestone
v2.0.1

Comments

@str4d
Copy link
Contributor

str4d commented Aug 27, 2018

Narrator: They never did.

@ebfull said:

I just wish this PR was more agnostic to the upgrade. As it stands, it's too overwinter-specific.

@str4d said:

We can always clean this up in 1.1.0 to be more generic.

We forgot to change this in 2.0.0. We should make this generic so that the NU levers are all in one place, and thus much less likely to be overlooked. Then at least 2.0.1 peers will benefit from the peer management strategy.
@str4d str4d added this to the v2.0.1 milestone Aug 27, 2018
@daira daira mentioned this issue Aug 31, 2018
Closed
@daira
Copy link
Contributor

daira commented Aug 31, 2018

#3338 was a duplicate.

@str4d
Copy link
Contributor Author

str4d commented Aug 31, 2018

It covered the logic in net.cpp, not ProcessMessages(), but I agree with folding it into this issue.

@str4d str4d self-assigned this Sep 12, 2018
@str4d str4d mentioned this issue Sep 12, 2018
Merged
zkbot added a commit that referenced this issue Sep 17, 2018
@zkbot
Auto merge of #3512 - str4d:3487-nu-peer-management, r=ebfull
f685a36 
Make NU peer management logic upgrade-agnostic

Closes #3487.
zkbot added a commit that referenced this issue Sep 18, 2018
@zkbot
Auto merge of #3512 - str4d:3487-nu-peer-management, r=ebfull
49356ed 
Make NU peer management logic upgrade-agnostic

Closes #3487.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@str4d str4d

Labels
A-networking Area: Networking code network upgrade management
Projects
None yet
Milestone
v2.0.1
Development

No branches or pull requests
2 participants
@daira @str4d