run automated tests for libsnark, libzerocash, and zerocashd

[daira]

Run automated tests for libsnark, libzerocash, and zerocashd; make sure that they pass before doing anything else.

[nathan-at-least]

Here is the upstream bitcoin's README.md Testing section which describes how to run tests. To execute unit tests:

make check

[nathan-at-least]

Should we rename this ticket to be specific to "automated tests" or "unit tests"?

I'm interested in deterministic tests which tell the user "success" or "failure" without much other noise, which makes it easy to quickly spot regressions. This would be in contrast to tests as in #71 which require a fair amount of user involvement.

[daira]

make check fails for me with the following error (looks like it can't find libzerocash):

  CXXLD    bitcoin-cli
libbitcoin_common.a(core.o): In function `CTxInZerocoinPourDataCacheEntry::CTxInZerocoinPourDataCacheEntry(CScript const&)':
/home/davidsarah/zecc/zerocashd/src/core.cpp:20: undefined reference to `libzerocash::PourTransaction::PourTransaction()'
/home/davidsarah/zecc/zerocashd/src/core.cpp:28: undefined reference to `libzerocash::PourTransaction::getSpentSerial1() const'
/home/davidsarah/zecc/zerocashd/src/core.cpp:32: undefined reference to `libzerocash::PourTransaction::getSpentSerial2() const'
/home/davidsarah/zecc/zerocashd/src/core.cpp:36: undefined reference to `libzerocash::PourTransaction::getNewCoinCommitmentValue1() const'
/home/davidsarah/zecc/zerocashd/src/core.cpp:40: undefined reference to `libzerocash::PourTransaction::getNewCoinCommitmentValue2() const'
/home/davidsarah/zecc/zerocashd/src/core.cpp:43: undefined reference to `libzerocash::PourTransaction::getMonetaryValueOut() const'
libbitcoin_common.a(core.o): In function `CTxInZerocoinMintDataCacheEntry::CTxInZerocoinMintDataCacheEntry(CScript const&)':
/home/davidsarah/zecc/zerocashd/src/core.cpp:46: undefined reference to `libzerocash::MintTransaction::MintTransaction()'
/home/davidsarah/zecc/zerocashd/src/core.cpp:54: undefined reference to `libzerocash::MintTransaction::getMintedCoinCommitmentValue() const'
/home/davidsarah/zecc/zerocashd/src/core.cpp:57: undefined reference to `libzerocash::MintTransaction::getMonetaryValue() const'
libbitcoin_common.a(script.o): In function `std::_Rb_tree<uint256, std::pair<uint256 const, CBlockIndex*>, std::_Select1st<std::pair<uint256 const, CBlockIndex*> >, std::less<uint256>, std::allocator<std::pair<uint256 const, CBlockIndex*> > >::find(uint256 const&) const':
/usr/include/c++/4.9/bits/stl_tree.h:1929: undefined reference to `mapBlockIndex'
libbitcoin_common.a(script.o): In function `EvalScript(std::vector<std::vector<unsigned char, std::allocator<unsigned char> >, std::allocator<std::vector<unsigned char, std::allocator<unsigned char> > > >&, CScript const&, CTransaction const&, unsigned int, unsigned int, int)':
/home/davidsarah/zecc/zerocashd/src/script.cpp:501: undefined reference to `mapBlockIndex'
/home/davidsarah/zecc/zerocashd/src/script.cpp:463: undefined reference to `libzerocash::MintTransaction::MintTransaction()'
/home/davidsarah/zecc/zerocashd/src/script.cpp:466: undefined reference to `libzerocash::MintTransaction::verify() const'
libbitcoin_common.a(script.o): In function `std::string::_Rep::_M_dispose(std::allocator<char> const&)':
/usr/include/c++/4.9/bits/basic_string.h:240: undefined reference to `mapBlockIndex'
libbitcoin_common.a(script.o): In function `std::_Rb_tree<uint256, std::pair<uint256 const, CBlockIndex*>, std::_Select1st<std::pair<uint256 const, CBlockIndex*> >, std::less<uint256>, std::allocator<std::pair<uint256 const, CBlockIndex*> > >::_M_lower_bound(std::_Rb_tree_node<std::pair<uint256 const, CBlockIndex*> > const*, std::_Rb_tree_node<std::pair<uint256 const, CBlockIndex*> > const*, uint256 const&) const':
/usr/include/c++/4.9/bits/stl_tree.h:1276: undefined reference to `mapBlockIndex'
libbitcoin_common.a(script.o): In function `EvalScript(std::vector<std::vector<unsigned char, std::allocator<unsigned char> >, std::allocator<std::vector<unsigned char, std::allocator<unsigned char> > > >&, CScript const&, CTransaction const&, unsigned int, unsigned int, int)':
/home/davidsarah/zecc/zerocashd/src/script.cpp:518: undefined reference to `libzerocash::PourTransaction::PourTransaction()'
/home/davidsarah/zecc/zerocashd/src/script.cpp:529: undefined reference to `pzerocashParams'
/home/davidsarah/zecc/zerocashd/src/script.cpp:529: undefined reference to `libzerocash::PourTransaction::verify(libzerocash::ZerocashParams&, std::vector<unsigned char, std::allocator<unsigned char> >&, std::vector<unsigned char, std::allocator<unsigned char> > const&) const'
collect2: error: ld returned 1 exit status
make[2]: *** [bitcoin-cli] Error 1
make[2]: Leaving directory `/home/davidsarah/zecc/zerocashd/src'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/home/davidsarah/zecc/zerocashd/src'
make: *** [check-recursive] Error 1

[imichaelmiers]

This may be a known error. Remember, libbitcoin_common should not compile period because of alterations I made in Script.cpp that depend on libzerocash functions. , while libzerocash is linked when you compile bitcoind, I at least never tried to get it to link into libbitcoin_common.
I think it’s a simple matter of changing what’s linked into libbitcoin_common when compiling .

Ian
On Jan 30, 2015, at 2:52 PM, Daira Hopwood notifications@github.com wrote:

make check fails for me with the following linking error (looks like it can't find libzerocash):

CXXLD bitcoin-cli
libbitcoin_common.a(core.o): In function CTxInZerocoinPourDataCacheEntry::CTxInZerocoinPourDataCacheEntry(CScript const&)': /home/davidsarah/zecc/zerocashd/src/core.cpp:20: undefined reference tolibzerocash::PourTransaction::PourTransaction()'
/home/davidsarah/zecc/zerocashd/src/core.cpp:28: undefined reference to libzerocash::PourTransaction::getSpentSerial1() const' /home/davidsarah/zecc/zerocashd/src/core.cpp:32: undefined reference tolibzerocash::PourTransaction::getSpentSerial2() const'
/home/davidsarah/zecc/zerocashd/src/core.cpp:36: undefined reference to libzerocash::PourTransaction::getNewCoinCommitmentValue1() const' /home/davidsarah/zecc/zerocashd/src/core.cpp:40: undefined reference tolibzerocash::PourTransaction::getNewCoinCommitmentValue2() const'
/home/davidsarah/zecc/zerocashd/src/core.cpp:43: undefined reference to libzerocash::PourTransaction::getMonetaryValueOut() const' libbitcoin_common.a(core.o): In functionCTxInZerocoinMintDataCacheEntry::CTxInZerocoinMintDataCacheEntry(CScript const&)':
/home/davidsarah/zecc/zerocashd/src/core.cpp:46: undefined reference to libzerocash::MintTransaction::MintTransaction()' /home/davidsarah/zecc/zerocashd/src/core.cpp:54: undefined reference tolibzerocash::MintTransaction::getMintedCoinCommitmentValue() const'
/home/davidsarah/zecc/zerocashd/src/core.cpp:57: undefined reference to libzerocash::MintTransaction::getMonetaryValue() const' libbitcoin_common.a(script.o): In functionstd::_Rb_tree<uint256, std::pair<uint256 const, CBlockIndex*>, std::_Select1st<std::pair<uint256 const, CBlockIndex*> >, std::less, std::allocator<std::pair<uint256 const, CBlockIndex*> > >::find(uint256 const&) const':
/usr/include/c++/4.9/bits/stl_tree.h:1929: undefined reference to mapBlockIndex' libbitcoin_common.a(script.o): In functionEvalScript(std::vector<std::vector<unsigned char, std::allocator >, std::allocator<std::vector<unsigned char, std::allocator > > >&, CScript const&, CTransaction const&, unsigned int, unsigned int, int)':
/home/davidsarah/zecc/zerocashd/src/script.cpp:501: undefined reference to mapBlockIndex' /home/davidsarah/zecc/zerocashd/src/script.cpp:463: undefined reference tolibzerocash::MintTransaction::MintTransaction()'
/home/davidsarah/zecc/zerocashd/src/script.cpp:466: undefined reference to libzerocash::MintTransaction::verify() const' libbitcoin_common.a(script.o): In functionstd::string::_Rep::_M_dispose(std::allocator const&)':
/usr/include/c++/4.9/bits/basic_string.h:240: undefined reference to mapBlockIndex' libbitcoin_common.a(script.o): In functionstd::_Rb_tree<uint256, std::pair<uint256 const, CBlockIndex*>, std::_Select1st<std::pair<uint256 const, CBlockIndex*> >, std::less, std::allocator<std::pair<uint256 const, CBlockIndex*> > >::M_lower_bound(std::Rb_tree_node<std::pair<uint256 const, CBlockIndex*> > const, std::Rb_tree_node<std::pair<uint256 const, CBlockIndex> > const, uint256 const&) const':
/usr/include/c++/4.9/bits/stl_tree.h:1276: undefined reference to mapBlockIndex' libbitcoin_common.a(script.o): In functionEvalScript(std::vector<std::vector<unsigned char, std::allocator >, std::allocator<std::vector<unsigned char, std::allocator > > >&, CScript const&, CTransaction const&, unsigned int, unsigned int, int)':
/home/davidsarah/zecc/zerocashd/src/script.cpp:518: undefined reference to libzerocash::PourTransaction::PourTransaction()' /home/davidsarah/zecc/zerocashd/src/script.cpp:529: undefined reference topzerocashParams'
/home/davidsarah/zecc/zerocashd/src/script.cpp:529: undefined reference to libzerocash::PourTransaction::verify(libzerocash::ZerocashParams&, std::vector<unsigned char, std::allocator<unsigned char> >&, std::vector<unsigned char, std::allocator<unsigned char> > const&) const' collect2: error: ld returned 1 exit status make[2]: *_\* [bitcoin-cli] Error 1 make[2]: Leaving directory /home/davidsarah/zecc/zerocashd/src'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory`/home/davidsarah/zecc/zerocashd/src'
make: *** [check-recursive] Error 1
—
Reply to this email directly or view it on GitHub.

[nathan-at-least]

Just noticed this old ticket. Current status:

• We run the upstream automated tests as part of ./qa/zerocash/full-test-suite.sh L32 at 1412d38a (latest on branch zc.v0.10.0.latest), which is in turn run by Travis-CI, see: ./.travis.yml L42 at 1412d38a (latest on branch zc.v0.10.0.latest)
• We have a Travis-CI spec for libzerocash: ./.travis.yml at 9fa0b792 (latest on branch zc.0ae3c6.latest) -but it doesn't appear to run automated tests yet.
• The state of libsnark is unknown to me atm.

[nathan-at-least]

I believe @ebfull removed Travis-CI because we've deprecated it in favor of self-hosted buildbot.

The status for self-hosted buildbot is as per my last comment here, except it's executed by buildbot (thus no "artificial" time/memory restrictions).

[daira]

We are testing libzerocash and zerocashd. I'll open another ticket for CI testing of libsnark.